Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sets env vars in the manager deployment #89

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: sets env vars in the manager deployment #89

merged 1 commit into from
Jan 27, 2022

Conversation

nbalacha
Copy link
Contributor

Env vars for the manager deployment were earlier set using a configmap.
That does not work well with the downstream build mirroring pipeline.
This fix sets the env vars directly in the manager deployment spec.

Signed-off-by: N Balachandran nibalach@redhat.com

Env vars for the manager deployment were earlier set using a configmap.
That does not work well with the downstream build mirroring pipeline.
This fix sets the env vars directly in the manager deployment spec.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit 3e8925b into openshift:main Jan 27, 2022
@nbalacha
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@nbalacha: new pull request created: #90

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants